Messages in this thread | | | Date | Wed, 5 Jul 2006 09:17:52 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [RFC 3/8] Move HIGHMEM counter into highmem.c/.h |
| |
On Wed, 05 Jul 2006 02:50:32 +1000 Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> Christoph Lameter wrote: > > On Mon, 3 Jul 2006, Andrew Morton wrote: > > > > > >>>Ok. Will put a #ifdef CONFIG_HIGHMEM around that statement and the > >>>following one. > >> > >>That will take the patchset up to 27 new ifdefs. Is there a way of improving > >>that? > > > > > > Ideas are welcome. I can put some of the tests for zones together into one > > big #ifdef in mmzone.h but otherwise this is going to be difficult. > > I don't think there's much point. They all look pretty straightforward, > and if you try doing something fancy it might just make it more fragile > or harder to read. > just one point. I'm not sure dropping "printing HIGHMEM statistics" stuff is good or not. It is shown in /proc/meminfo even if CONFIG_HIGHMEM=n now. this will change look of user interface a bit. but maybe not so important ....
-Kame
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |