lkml.org 
[lkml]   [2006]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [openib-general] [PATCH] mthca: initialize send and receive queue locks separately
From
Date
    Zach> Also, while looking at this I saw that the locks are being
Zach> re-initialized from mthca_modify_qp(). Is that just a
Zach> side-effect of relying on mthca_wq_init() to reset the
Zach> non-lock members? If you're concerned about
Zach> microoptimization it seems like this could be avoided.

I think that is actually a very minor bug you've found. If someone
were posting a work request at the same time as they transitioned a QP
to reset (which is a legitimate if not sensible thing to do), then the
spinlock could get reinitialized while it was held. Which would be
bad. So I think I like your original patch the best.

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-04 23:24    [W:0.565 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site