lkml.org 
[lkml]   [2006]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: REGRESSION: the new i386 timer code fails to sync CPUs
From
Hi,

Andrew Morton:
> > Hack out the i386 TSC sync code.
> >
> > diff --git a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c
> > index 6f5fea0..cd28914 100644
> > --- a/arch/i386/kernel/smpboot.c
> > +++ b/arch/i386/kernel/smpboot.c
> > @@ -435,7 +435,7 @@ static void __devinit smp_callin(void)
> > /*
> > * Synchronize the TSC with the BP
> > */
> > - if (cpu_has_tsc && cpu_khz && !tsc_sync_disabled)
> > + if (0 && cpu_has_tsc && cpu_khz && !tsc_sync_disabled)
> > synchronize_tsc_ap();
> > }
> >
> > @@ -1305,7 +1305,7 @@ static void __init smp_boot_cpus(unsigne
> > /*
> > * Synchronize the TSC with the AP
> > */
> > - if (cpu_has_tsc && cpucount && cpu_khz)
> > + if (0 && cpu_has_tsc && cpucount && cpu_khz)
> > synchronize_tsc_bp();
> > }
>
> I guess Matthias didn't test this patch. Can we get some obviously-correct
> fix in place for 2.6.18?
>
This patch doesn't change the problem.

--
Matthias Urlichs | {M:U} IT Design @ m-u-it.de | smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
- -
Success is always being able to wear clothing that you actually like.
-- SJM
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-07-31 16:29    [W:0.792 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site