Messages in this thread | | | Date | Sun, 30 Jul 2006 12:52:28 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 5/6] Begin abstraction of sensitive instructions: asm files |
| |
On Sat 2006-07-22 10:14:34, Rusty Russell wrote: > (forgot to send this to lkml before) > > Abstract sensitive instructions in assembler code, replacing them with > macros (which currently are #defined to the native versions). We use > long names: assembler is case-insensitive, so if something goes wrong > and macros do not expand, it would assemble anyway. > > Resulting object files are exactly the same as before. > > Signed-off-by Rusty Russell <rusty@rustcorp.com.au> > > Index: working-2.6.18-rc2-hg-paravirt/arch/i386/kernel/entry.S > =================================================================== > --- working-2.6.18-rc2-hg-paravirt.orig/arch/i386/kernel/entry.S 2006-07-21 21:09:22.000000000 +1000 > +++ working-2.6.18-rc2-hg-paravirt/arch/i386/kernel/entry.S 2006-07-22 04:32:25.000000000 +1000 > @@ -76,8 +76,15 @@ > NT_MASK = 0x00004000 > VM_MASK = 0x00020000 > > +/* These are replaces for paravirtualization */ > +#define DISABLE_INTERRUPTS cli > +#define ENABLE_INTERRUPTS sti > +#define ENABLE_INTERRUPTS_SYSEXIT sti; sysexit > +#define INTERRUPT_RETURN iret
Could we use some less verbose names, like possibly CLI, STI, STI_SYSEXIT, IRET ?
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |