lkml.org 
[lkml]   [2006]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.17-mm6
On Mon, 03 Jul 2006 10:25:45 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Sergey Vlasov wrote:
> > These names are truncated - they should end with two hex digits:
> >
> > snprintf(device->bus_id, sizeof(device->bus_id), "%s:pcie%02x",
> > pci_name(parent), get_descriptor_id(port_type, service_type));
> >
> > Names were truncated at 18 characters, but sizeof(device->bus_id) is 20
> > currently, so these names should just fit there. I see that snprintf()
> > was changed recently - maybe there is some off-by-one bug there?
> >

Darnit, I was staring at the wrong code so much that I never even noticed that.

> There was for a while, but it should be OK in -mm6. Perhaps there's a
> stray patch hanging around in this kernel?
>

No, it's still wrong.

end = buf + size - 1;
...
end[-1] = '\0';


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-03 21:04    [W:0.156 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site