Messages in this thread Patch in this message | | | Date | Sat, 29 Jul 2006 16:20:24 -0400 | From | Neil Horman <> | Subject | Re: [KJ] (re) audit return code handling for kernel_thread [3/3] |
| |
Patch to audit return codes for kernel_thread. This patch corrects callers who have differing assumptions about the meaning of a zero return code. I've normalized all the callers to consider a zero return code a successful return.
Thanks & Regards Neil
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
arch/ia64/sn/kernel/xpc_main.c | 2 +- init/do_mounts_initrd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
--- a/arch/ia64/sn/kernel/xpc_main.c +++ b/arch/ia64/sn/kernel/xpc_main.c @@ -583,7 +583,7 @@ xpc_activate_partition(struct xpc_partit pid = kernel_thread(xpc_activating, (void *) ((u64) partid), 0); - if (unlikely(pid <= 0)) { + if (unlikely(pid < 0)) { spin_lock_irqsave(&part->act_lock, irq_flags); part->act_state = XPC_P_INACTIVE; XPC_SET_REASON(part, xpcCloneKThreadFailed, __LINE__); --- a/init/do_mounts_initrd.c +++ b/init/do_mounts_initrd.c @@ -57,7 +57,7 @@ static void __init handle_initrd(void) current->flags |= PF_NOFREEZE; pid = kernel_thread(do_linuxrc, "/linuxrc", SIGCHLD); - if (pid > 0) { + if (pid >= 0) { while (pid != sys_wait4(-1, NULL, 0, NULL)) yield(); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |