Messages in this thread | | | Date | Fri, 28 Jul 2006 08:15:20 +0200 | From | Martin Peschke <> | Subject | Re: [Patch 1/2] CPU hotplug compatible alloc_percpu |
| |
Paul Jackson wrote: > Martin wrote: >> +static inline int percpu_populate_mask(void *__pdata, size_t size, gfp_t gfp, >> + int cpu) >> +{ > > It seems odd to me that this signature of percpu_populate_mask() > has its last argument 'int cpu' for the !CONFIG_SMP case, but > the SMP signatures have 'cpumask_t mask'. > > Shouldn't this function signature be the same for all CONFIG's?
Looks like a mistake. Luckily, it won't cause any harm, though. I will send a patch.
Thank you for reviewing.
Martin
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |