[lkml]   [2006]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Patch 1/2] CPU hotplug compatible alloc_percpu
Paul Jackson wrote:
> Martin wrote:
>> +static inline int percpu_populate_mask(void *__pdata, size_t size, gfp_t gfp,
>> + int cpu)
>> +{
> It seems odd to me that this signature of percpu_populate_mask()
> has its last argument 'int cpu' for the !CONFIG_SMP case, but
> the SMP signatures have 'cpumask_t mask'.
> Shouldn't this function signature be the same for all CONFIG's?

Looks like a mistake. Luckily, it won't cause any harm, though.
I will send a patch.

Thank you for reviewing.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-07-28 08:17    [W:0.056 / U:2.780 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site