Messages in this thread | | | Date | Fri, 28 Jul 2006 08:04:46 +0400 | From | Alexey Dobriyan <> | Subject | Re: Support for TI FlashMedia (pci id 104c:8033, 104c:803b) flash card readers |
| |
On Thu, Jul 27, 2006 at 08:34:06PM -0700, Alex Dubov wrote: > The driver is called tifmxx and available from: > http://developer.berlios.de/projects/tifmxx/
1. Usual name for spinlocking flags is
unsigned long flags;
2. Preferred CS for if statements is
if (foo) bar; /* two lines no matter how short */
3. Check for NULL at the start of tifm_7xx1_remove is unnecessary. You've saved valid fm at probe time, right?
4. If ->suspend and ->resume are not implemented why add dummy ones?
5.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |