Messages in this thread |  | | | Date | Fri, 28 Jul 2006 09:34:11 -0700 | | From | "Handle X" <> | | Subject | Re: [RFC] #define rwxr_xr_x 0755 |
| |
On 7/27/06, Björn Steinbrink <B.Steinbrink@gmx.de> wrote: > On 2006.07.28 00:59:11 +0400, Alexey Dobriyan wrote: > > Every time I try to decipher S_I* combos I cry in pain. Often I just > > refer to include/linux/stat.h defines to find out what mode it is > > because numbers are actually quickier to understand. > > > > Compare and contrast: > > > > 0644 vs S_IRUGO|S_IWUSR vs rw_r__r__ > > > > I'd say #2 really sucks. > > IMHO #3 sucks more, it's not as easy to spot when glossing over the > code, the underscores make it quite ugly (think _r________) and it's > less "greppable". If I know that there's something that sets S_ISUID, I > can easily search for that, compare that to [_cpdbl]{1}[r_]{1}[w_]{1}s... I agree with Steinbink. But how about having macros like, S_I0700, S_I0070, S_I6444 ..etc. They combine visual appeal of octals, easy to grep, easy to decipher ...etc.
Regards, Om. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |