Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 28 Jul 2006 16:59:47 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH/RFC] kconfig/lxdialog: make lxdialof a built-in |
| |
On Fri, Jul 28, 2006 at 04:09:03PM +0200, Roman Zippel wrote: > Hi, > > On Thu, 27 Jul 2006, Sam Ravnborg wrote: > > > Dedided to take another stamp on an old TODO item of making lxdialog > > a built-in. Following patch is first step to do so. > > The patch makes it a built-in - but with two open issues that I yet > > have to address. > > Looks good. :) > There is a NULL pointer problem with empty menus, item_cur is NULL and a > select or exit will cause a segfault in item_set_selected(). Fixed. Introduced a dummy variable "item_nil" that item_cur points to in the empty case. So no need for special cases all over.
> > > I will during the weekend try to address the resize issue. > > Wasn't it working at some point? > Anyway, it doesn't has to be overly complex either, e.g. if you delay it > to the next key event, it's fine too. The signal handler would just set a > flag and when wgetch returns, the display is reinitialized. My experiments so far tells me that a resize generates KEY_RESIZE so it is a simple matter of handling KEY_RESIZE correct in the different dialog_* functions - and no signal handler needed. Thats looks like the approach taken in the dialog package too.
> > > The double ESC ESC thing I dunno how to fix. > > I think the easiest would be to just ignore the first ESC, it matches the > documented behaviour and e.g. mc has the same behaviour. The delay of the > single ESC makes it a bit annoying/confusing to use, so that sticking to > the double ESC is IMO safer. > I played with it a little and below is an example, which implements this > behaviour for the menu window.
Thanks - will implment this for all the dialog_* functions.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |