lkml.org 
[lkml]   [2006]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: restore missing PCI registers after reset
    Quoting r. Greg KH <gregkh@suse.de>:
    > Subject: [patch 02/45] IB/mthca: restore missing PCI registers after reset
    > ------------------
    > mthca does not restore the following PCI-X/PCI Express registers after reset:
    > PCI-X device: PCI-X command register
    > PCI-X bridge: upstream and downstream split transaction registers
    > PCI Express : PCI Express device control and link control registers
    >
    > This causes instability and/or bad performance on systems where one of
    > these registers is set to a non-default value by BIOS.
    >
    > Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
    > Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    By the way, Greg, this code is completely generic, and the same seems to apply
    to all PCI-X/PCI-Express devices - should not pci_restore_state and
    friends really know about these registers, as well?

    What do you think?

    --
    MST
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-26 12:31    [W:0.030 / U:0.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site