lkml.org 
[lkml]   [2006]   [Jul]   [26]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
DateTue, 25 Jul 2006 22:17:21 -0700 (PDT)
FromKomal Shah <>
SubjectRe: [PATCH] OMAP: Add keypad driver #2
--- Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> 
> Hi Komal,
> 
> The driver needs to handle failures in input_register_device() and
> unwind initialization properly. Also you do not need to do double
> negation of the value when calling input_report_key() because it will
> do it for you.
> 
> Also you might consider setting up keycodetable, keycodesize, etc in
> the input device - this way you can change keymap at runtime via
> ioctls.

Thanx for the review. I will update the driver and submit to list soon.


---Komal Shah
http://komalshah.blogspot.com/
__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-07-26 05:21    [W:1.897 / U:0.070 seconds]
©2003-2008 Jasper Spaans