lkml.org 
[lkml]   [2006]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [3/4] kevent: AIO, aio_sendfile() implementation.
    On Wed, Jul 26, 2006 at 11:00:13AM +0100, Christoph Hellwig (hch@infradead.org) wrote:
    > > struct address_space_operations ext2_aops = {
    > > + .get_block = ext2_get_block,
    >
    > No way in hell. For whatever you do please provide a interface at
    > the readpage/writepage/sendfile/etc abstraction layer. get_block is
    > nothing that can be exposed to the common code.

    Compare this with sync read methods - all they do is exactly the same
    operations with low-level blocks, which are combined into nice exported
    function, so there is _no_ readpage layer - it calls only one function
    which works with blocks.

    I would create the same, i.e. async_readpage(), which called kevent's
    functions and processed low-level blocks, just like sync code does, but
    that requires kevent to be deep part of the FS tree.

    So I prefer to have
    kevent/some_function_which_works_with_blocks_and_kevents()

    instead of
    fs/some_function_which_works_with_block_and_kevents()
    kevent/call_that_function_like_all_readpage_callbacks_do().

    So it is not a technical problem, but political one.
    --
    Evgeniy Polyakov
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-26 12:11    [W:2.749 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site