Messages in this thread | | | Date | Thu, 27 Jul 2006 00:59:44 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH] vm/agp: remove private page protection map |
| |
On Thu, 27 Jul 2006, Dave Airlie wrote: > > agp_convert_mmap_flags still using its own conversion from PROT_ to VM_ > > while there's an inline in mm.h (though why someone thought to optimize
My mistake: calc_vm_prot_bits() is actually in include/linux/mman.h (which you are already #including, so no problem).
> > AGP keeps its own copy of the protection_map, upcoming DRM changes will > > also require access to this map from modules. > > > > Signed-off-by: Hugh Dickins <hugh@veritas.com> > > Signed-of-by: Dave Airlie <airlied@linux.ie>
Thanks. By the way, I hope you noticed that some architectures (arm, m68k, sparc, sparc64) may adjust protection_map[] at startup: so the old agp_convert_mmap_flags would supply the compiled in prot, whereas the new agp_convert_mmap_flags supplies the adjusted prot.
I assume this is either irrelevant to you (no AGP on some arches?) or an improvement (the adjusted prot more appropriate); but if you weren't aware of it, please do check that those do what you want.
Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |