Messages in this thread | | | Date | Wed, 26 Jul 2006 14:48:04 +0300 (EEST) | From | Pekka J Enberg <> | Subject | Re: [patch] slab: always follow arch requested alignments |
| |
On Wed, 26 Jul 2006, Christoph Lameter wrote: > If you disable them then we are fine. I think the main "bug" is that > we create the caches with ARCH_KMALLOC_MINALIGN in kmem_cache_init but > allow debug options on them. It seemss that we need to be able to disable > debugging from kmem_cache_init.
No, as Heiko explained, but bug is that we fail to respect architecture and caller mandated alignment when CONFIG_SLAB_DEBUG is enabled. With this patch (or Heiko's), we should be okay: http://lkml.org/lkml/2006/7/26/93
Note that this will fix the kmem_cache_init() case too. If ARCH_KMALLOC_MINALIGN is greater than BYTES_PER_WORD, we'll disable debugging for those caches. It's obviously ok to have debugging for kmem_cache_init caches too if ARCH_KMALLOC_MINALIGN is greater than or equal to BYTES_PER_WORD.
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |