Messages in this thread | | | Date | Tue, 25 Jul 2006 13:57:16 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: remove cpu hotplug bustification in cpufreq. |
| |
On Tue, 25 Jul 2006, Arjan van de Ven wrote: > > so cpufreq_set_policy() takes policy->lock, and then calls into the > userspace governer code > (__cpufreq_set_policy->cpufreq_governor->cpufreq_governor_userspace) > which calls __cpufreq_driver_target... which does lock_cpu_hotplug().
Yeah. I think the target should _not_ take the lock_cpu_hotplug(), since the call chain (much much earlier) should have done it.
Ie we should probably do it at the "cpufreq_set_policy()" level.
> Arjan -- who's just cleaned Linus' wall to prepare it for more head > banging
It's not actually "my wall". I'll happily share it with anybody else.
Please. Take my wall.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |