Messages in this thread | | | Date | Tue, 25 Jul 2006 00:56:54 +0200 | From | Pavel Machek <> | Subject | Re: [patch] [resend] Fix swsusp with PNP BIOS |
| |
On Mon 2006-07-24 23:25:50, Rafael J. Wysocki wrote: > Hi, > > On Monday 24 July 2006 20:28, Ondrej Zary wrote: > > Hello, > > swsusp is unable to suspend my machine (DTK FortisPro TOP-5A notebook) with > > kernel 2.6.17.5 because it's unable to suspend PNP device 00:16 (mouse). > > > > The problem is in PNP BIOS. pnp_bus_suspend() calls pnp_stop_dev() for the > > device if the device can be disabled according to pnp_can_disable(). The > > problem is that pnpbios_disable_resources() returns -EPERM if the device is > > not dynamic (!pnpbios_is_dynamic()) but insert_device() happily sets > > PNP_DISABLE capability/flag even if the device is not dynamic. So we try to > > disable non-dynamic devices which will fail. > > This patch prevents insert_device() from setting PNP_DISABLE if the device is > > not dynamic and fixes suspend on my system. > > Thanks for the patch. > > Pavel, what do you think?
Knowing nothing about pnpbios it looks okay to me. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |