lkml.org 
[lkml]   [2006]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] Use target filename in BUG_ON and friends
On Mon, Jul 10, 2006 at 02:03:07AM +0200, Andi Kleen wrote:
> On Saturday 08 July 2006 22:57, Sam Ravnborg wrote:
> > On Sat, Jul 08, 2006 at 11:45:49AM -0500, Milton Miller wrote:
> > >
> > > On Jul 8, 2006, at 04:45:54 EST, Sam Ravnborg wrote:
> > > > When building the kernel using make O=.. all uses of __FILE__ becomes
> > > > filenames with absolute path resulting in increased text size.
> > > > Following patch supply the target filename as a commandline define
> > > > KBUILD_TARGET_FILE="mmslab.o"
> > >
> > > Unfortunately this ignores the fact that __LINE__ is meaningless
> > > without __FILE__ because there are way too many BUGs in header
> > > files.
> >
> > __LINE__ gives a very precise hint of the offending .h file.
> > For x86_64 there are only one line-number clash in include/ for uses of
> > __FILE__.
>
>
> It's a nasty encoding. Maybe you could add a script to resolve them?
The patch was dropped. The benefit was too small compared to less
readable bug's.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-23 20:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site