lkml.org 
[lkml]   [2006]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.
    Pekka J Enberg wrote:
    > At least Andrew seems to prefer cleaning up in the same patch. Anyway, I
    > don't think Jeff meant that you shouldn't do any cleanups, but that you
    > should try to respect the existing style as much possible.

    First and foremost, respect that the Linux sources need to have a
    minimum level of stylistic uniformity.

    > There are
    > things that are almost generally agreed upon, such as removal of redundant
    > typecasts, redundant wrappers, and moving assignment out of if statement
    > expression. Formatting and the dreaded sizeof thing, however,
    > are not, so it is best to keep them as-is.

    Contributors can't know what the (supposed) _agreements_ are.

    Contributors can only know what the _documented conventions_ are.
    --
    Stefan Richter
    -=====-=-==- -=== =--==
    http://arcgraph.de/sr/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-21 13:09    [W:0.019 / U:62.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site