Messages in this thread | | | Subject | Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc. | From | Panagiotis Issaris <> | Date | Fri, 21 Jul 2006 12:42:59 +0200 |
| |
On vr, 2006-07-21 at 13:14 +0300, Pekka J Enberg wrote: > On Fri, 21 Jul 2006, Panagiotis Issaris wrote: > > Ah okay. Up until now, I thought it would be okay to change the style of > > the code if it was listed in the CodingStyle document and in any other > > cause should be left untouched as it would be left to the maintainers > > personal preference. That's why I explicitly asked about the "if ((buf = > > kmalloc(...)==NULL) -> buf = kmalloc(...); if (!buf)" type of changes. > > > > Ofcourse, I should have put cosmetic changes in a separate patch anyway. > > At least Andrew seems to prefer cleaning up in the same patch. Anyway, I > don't think Jeff meant that you shouldn't do any cleanups, but that you > should try to respect the existing style as much possible. There are > things that are almost generally agreed upon, such as removal of redundant > typecasts, redundant wrappers, and moving assignment out of if statement > expression. Formatting and the dreaded sizeof thing, however, > are not, so it is best to keep them as-is. Thank God! I had been preparing such a cleanup patch for several hours last night :)
With friendly regards, Takis
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |