Messages in this thread | | | Date | Fri, 21 Jul 2006 17:19:22 -0700 | From | Andrew Morton <> | Subject | Re: [RFC/PATCH] revoke/frevoke system calls |
| |
On Thu, 20 Jul 2006 15:07:30 +0300 (EEST) Pekka J Enberg <penberg@cs.Helsinki.FI> wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi> > > This patch implements the revoke(2) and frevoke(2) system calls for all > types of files. > > ... > > - file = fget_light(fd, &fput_needed); > + file = fget(fd);
This is sad.
> +static int revoke_files(struct task_struct *owner, struct inode *inode, > + struct file *exclude, struct list_head *to_close) > +{ > ... > + spin_lock(&files->file_lock); > ... > + revoked = kmalloc(sizeof(*revoked), GFP_KERNEL);
This is bad. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |