Messages in this thread |  | | | Date | Fri, 21 Jul 2006 15:55:41 -0700 (PDT) | | From | Trent Piepho <> | | Subject | Re: [v4l-dvb-maintainer] Re: [PATCH] V4L: struct video_device corruption |
| |
On Fri, 21 Jul 2006, Mauro Carvalho Chehab wrote: > config VIDEO_BT848 > tristate "BT848 Video For Linux" > depends on VIDEO_DEV && PCI && I2C && VIDEO_V4L2 > > Argh! it should be V4L1 instead!
You can compile and use bt848 without V4L1 turned on. It still has some V4L1 functions defined.
> > All these files include v4l2-dev.h and have HAVE_V4L1 defined when V4L1 is > > not turned on in Kconfig. There files are all buildable when V4L1 is off; > > they don't depend on it in Kconfig. > Some of the above drivers are V4L2, like tda9887, tuner-core, > tuner-simple, msp3400, cs53l32a, tveeprom, wm87xx. Maybe they are just > including the wrong headers. We should try to change to videodev2.h and > see what happens with all those drivers. The ones that break should me > marked with the proper requirement on Kconfig. > > Some of they need some #ifdef inside. For example, compat_ioctl32 should > handle both APIs, since it is a generic code to fix 32 bit calls to 64 > bit kernel.
I think this is pretty much what I've been saying. Drivers should: A. Not include videodev.h, but use videodev2.h B. Include videodev.h, but be marked V4L1 in Kconfig C. #ifdef around videodev.h (and code that needs videodev.h), so it is not included or needed when V4L1 is turned off. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |