Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [RFC] Apple Motion Sensor driver | Date | Sun, 2 Jul 2006 22:33:41 -0400 |
| |
Hi Michael,
On Sunday 02 July 2006 18:26, Michael Hanselmann wrote: > > + > + if (x) > + *x = tmpx; > + if (y) > + *y = tmpy; > + if (z) > + *z = tmpz;
All callers of ams_sensors use all 3 arguments, why bother with temps?
> + > + ams.idev->name = "Apple Motion Sensor"; > + ams.idev->id.bustype = BUS_I2C;
Should it be always BUS_I2C? Maybe it should be BUS_HOST in case of PMU?
> + ams.idev->id.vendor = 0;
Please add:
ams.idev->cdev.dev = &ams.of_dev->dev;
so that the input device has a proper parent in sysfs hierarchy.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |