lkml.org 
[lkml]   [2006]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 05/33] Makefile support to build Xen subarch
On Tue, 18 Jul 2006 12:00:13 +0200
Arjan van de Ven <arjan@infradead.org> wrote:

> On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote:
> > plain text document attachment (i386-mach-xen)
> > Use arch/i386/mach-xen when building Xen subarch. The separate
> > subarchitecture allows us to hide details of interfacing with the
> > hypervisor from i386 common code.
>
>
> Hi,
>
> please change the order of your patches next time, by sending the
> makefile and config options first you'll break git bisect...
>

No, this patch is OK (in that respect). As long as the git-bisect user
sets CONFIG_XEN=n (and surely he will), things will compile.

That being said,

+mflags-$(CONFIG_X86_XEN) := -Iinclude/asm-i386/mach-xen
+mcore-$(CONFIG_X86_XEN) := mach-xen
+
# generic subarchitecture
mflags-$(CONFIG_X86_GENERICARCH) := -Iinclude/asm-i386/mach-generic
mcore-$(CONFIG_X86_GENERICARCH) := mach-default
@@ -99,6 +103,7 @@ drivers-$(CONFIG_PM) += arch/i386/powe

CFLAGS += $(mflags-y)
AFLAGS += $(mflags-y)
+CPPFLAGS += $(mflags-y)

This change affects _all_ subarchitectures (by potentially altering their
CPPFLAGS) and it's rather a mystery why one subarch needs the -Ifoo in its
CPPFLAGS whereas all the others do not.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-18 13:45    [W:0.194 / U:1.892 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site