lkml.org 
[lkml]   [2006]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm patch] drivers/char/pc8736x_gpio.c: remove unused static functions
Adrian Bunk wrote:
> On Thu, Jul 13, 2006 at 10:48:00PM -0700, Andrew Morton wrote:
>
>> ...
>> Changes since 2.6.18-rc1-mm1:
>> ...
>> +gpio-drop-vtable-members-gpio_set_high-gpio_set_low.patch
>> ...
>> Misc fixes and updates and cleanups.
>> ...
>>
>
> This patch removes two no longer used static functions fixing the
> following gcc warnings:
>
> <-- snip -->
>
> ...
> CC drivers/char/pc8736x_gpio.o
> drivers/char/pc8736x_gpio.c:192: warning: #pc8736x_gpio_set_high# defined but not used
> drivers/char/pc8736x_gpio.c:197: warning: #pc8736x_gpio_set_low# defined but not used
> ...
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
>
yes please. and thanks.

Acked-by: Jim Cromie <jim.cromie@gmail.com>

( I delayed this reply, thinking it unnecessary to ack an obviously
correct patch.
Then rethought, figuring for explicit closure instead of tacit agreement. )



FYI, Im currently using these patches on -mm2, cursory tests show no
regressions.
# Adrian's trims
scx200_gpio.c-make-code-static.eml (my edited/reversed-effect version)
drivers_char_pc8736x_gpio.c-remove-unused-static-functions.eml
# Chris Boot's led patches
scx200_gpio-export-cleanups.eml
net48xx-led-use-gpio-ops.patch


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-18 18:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site