Messages in this thread | | | Date | Mon, 17 Jul 2006 14:38:58 -0400 | From | Jeff Mahoney <> | Subject | Re: [PATCH] reiserfs: fix handling of device names with /'s in them |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hans Reiser wrote: > Jeff Mahoney wrote: > >> Hans Reiser wrote: >> >>> I don't understand your patch and cannot support it as it is written. >>> Perhaps you can call me and explain it on the phone. >> >> I seriously can't tell if you're deliberately trying to be difficult or >> not. It's a simple "replace / with ! before sending the name to procfs." >> >> Reiserfs requests that a procfs directory called >> /proc/fs/reiserfs/<blockdev> be created. Some block devices contain >> slashes, so with cciss/c123 it attempts to create a directory called >> /proc/fs/reiserfs/cciss/c123, but cciss/ doesn't exist, shouldn't, and >> never will. > > Why not check to see if it does not exist, and create it if not, as > needed, and skip the !'s....?
1) Because then the behavior of /proc/fs/reiserfs/ would be inconsistent. Devices that contain slashes end up being one level deeper than other devices, which is silly and a userspace visible change. Tools that wish to parse the information would then need added complexity to traverse into the next level to reach that information.
2) The block-device-as-path-name-component behavior is already defined by sysfs (/sys/block), and it should be consistent.
- -Jeff
- -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFEu9lCLPWxlyuTD7IRAjeSAJ43f0SU1g4oivcUaFHQnnIPS89VMQCgkYu/ 8S3Qi0cM7mKuwhp9W51JjsY= =EXCL -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |