lkml.org 
[lkml]   [2006]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 34/45] ALSA: hda-intel - Fix race in remove
    -stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Takashi Iwai <tiwai@suse.de>

    [PATCH] ALSA: hda-intel - Fix race in remove

    Call iounmap after free_irq to avoid invalid accesses in the
    shared irq. The patch is taken from
    https://bugzilla.novell.com/show_bug.cgi?id=167869

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    sound/pci/hda/hda_intel.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- linux-2.6.17.6.orig/sound/pci/hda/hda_intel.c
    +++ linux-2.6.17.6/sound/pci/hda/hda_intel.c
    @@ -1393,10 +1393,10 @@ static int azx_free(struct azx *chip)
    msleep(1);
    }

    - if (chip->remap_addr)
    - iounmap(chip->remap_addr);
    if (chip->irq >= 0)
    free_irq(chip->irq, (void*)chip);
    + if (chip->remap_addr)
    + iounmap(chip->remap_addr);

    if (chip->bdl.area)
    snd_dma_free_pages(&chip->bdl);
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-17 18:37    [W:0.023 / U:64.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site