lkml.org 
[lkml]   [2006]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] reiserfs: fix handling of device names with /'s in them
    So the Plan 9 and Unix way would be to let the driver parse the number
    part of the name after the last slash. What I don't understand is why
    reiserfs is getting involved here, rather than recognizing the driver as
    an extension of the namespace, seeing the driver as a mountpoint, and
    just passing number to the driver. There must be something I don't
    grasp here, can you help me?

    Hans

    Jeff Mahoney wrote:

    > Bodo Eggert wrote:
    >
    > >Eric Dumazet <dada1@cosmosbay.com> wrote:
    >
    > >>On Wednesday 12 July 2006 18:42, Jeff Mahoney wrote:
    >
    > >>> On systems with block devices containing slashes (virtual dasd, cciss,
    > >>> etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to
    > >>> it being interpreted as a subdirectory. The generic block device code
    > >>> changes the / to ! for use in the sysfs tree. This patch uses that
    > >>> convention.
    > >>>
    > >>> Tested by making dm devices use dm/<number> rather than dm-<number>
    > >>
    > >>Your patch handles at most one slash. But the description mentions
    > 'slashes'
    > >>(ie several slashes)
    >
    > >Besides that, there is no reason to prevent the user from using many
    > slashes.
    > >OTOH, I'd prefer propper quoting, but having each driver do this would be
    > >insane.
    >
    >
    > The strings aren't user-supplied, they're kernel-internal names of block
    > devices, supplied by the driver. At present there is no possibility of
    > more than one slash in the name, and I doubt we'll see any new devices
    > with one slash in them, never mind more than one.
    >
    > -Jeff
    >
    > --
    > Jeff Mahoney
    > SUSE Labs

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-16 09:15    [W:0.029 / U:119.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site