lkml.org 
[lkml]   [2006]   [Jul]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 14 Jul 2006 22:40:01 -0700 (PDT)
SubjectRe: 2.6.18-rc1-mm2
FromDavid Miller <>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 15 Jul 2006 11:06:45 +1000

> -	__ret;						\
> +	unlikely(__ret);				\

Wouldn't it be cleaner to wrap this unlikely around
the top-level "({ })"?  When it sits on a line by
itself it looks strange, that much is true :)
Actually, the last time I saw a construct like this
it was a bug, someone was doing:

	return unlikely(someval);

which turned someval into a boolean, even though what
was intended was that the full value was returned.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-15 07:43    [from the cache]
©2003-2008