lkml.org 
[lkml]   [2006]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH -mm 5/7] add user namespace
    Date
    Dave Hansen <haveblue@us.ibm.com> writes:

    > On Fri, 2006-07-14 at 10:49 -0600, Eric W. Biederman wrote:
    >> - if (current->fsuid == inode->i_uid)
    >> + if ((current->fsuid == inode->i_uid) &&
    >> + (current->nsproxy->user_ns == inode->i_sb->user_ns))
    >> mode >>= 6;
    >
    > I really don't think assigning a user namespace to a superblock is the
    > right way to go. Seems to me like the _view_ into the filesystem is
    > what you want to modify. That would seem to me to mean that each
    > 'struct namespace' (filesystem namespace) or vfsmount would be assigned
    > a corresponding user namespace, *not* the superblock.

    I guess since you can't bind mount across filesystem namespaces looking
    at the vfsmount is ok, and more flexible.

    But inode->i_sb->user_ns or nd->mnt->user_ns isn't nearly as important
    as simply comparing some the appropriate user_ns values.

    Eric
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-07-14 19:19    [W:0.022 / U:179.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site