lkml.org 
[lkml]   [2006]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] remove volatile from x86 cmos_lock
From
Date
On Fri, 2006-07-14 at 16:53 +0200, Oliver Neukum wrote:
> Am Freitag, 14. Juli 2006 16:48 schrieb Steven Rostedt:
> > @@ -52,14 +54,16 @@ static inline void lock_cmos(unsigned ch
> >
> > static inline void unlock_cmos(void)
> > {
> > - cmos_lock = 0;
> > + set_wmb(cmos_lock, 0);
> > }
> > static inline int do_i_have_lock_cmos(void)
> > {
> > + barrier();
>
> Shouldn't these be rmb() ?

I was thinking that too, but I'm still not sure when to use rmb or
barrier. wmb seems pretty straight forward though. hmm, maybe this
really should be a smb_rmb since I believe a barrier would be ok for UP.

-- Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-14 17:13    [W:0.037 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site