Messages in this thread | | | Date | Thu, 13 Jul 2006 16:00:18 -0700 | From | Sukadev Bhattiprolu <> | Subject | Re: [PATCH] kthread: airo.c |
| |
Christoph Hellwig [hch@infradead.org] wrote: | On Thu, Jul 13, 2006 at 01:53:19PM -0700, Sukadev Bhattiprolu wrote: | > Andrew, | > | > Javier Achirica, one of the major contributors to drivers/net/wireless/airo.c | > took a look at this patch, and doesn't have any problems with it. It doesn't | > fix any bugs and is just a cleanup, so it certainly isn't a candidate | > for this mainline cycle | | I'm not sure it's that easy. I think it needs some more love: | | - switch to wake_uo_process | - kill JOB_DIE | - cleanup a the convoluted mess in airo_thread a bit | | Note that it's still reimplementing the single threaded workqueue | functionality quite badly. So if someone could switch it over and while | we're at it try to kill the idiociy of doing the trylock in the calling | context and only then calling the thread by always calling the thread | (which also solves the synchronization problem). | | Anywhy, here's a small incremental patch ontop of yours to implement my | above items:
I had a quick look at your patch and looks fine to me. I agree we could do more to clean up the driver.
My inital goal was to replace kernel_thread() with kthread_*(). So can I assume you are ok with my patch and that it can go in as is ?
Suka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |