Messages in this thread | | | Subject | RE: [PATCH] ia64: race flushing icache in COW path | Date | Thu, 13 Jul 2006 13:37:17 -0700 | From | "Luck, Tony" <> |
| |
> lazy_mmu_prot_update() is used in a number of other places *after* the pte > is established. An explanation as to why this case is different, would be > interesting.
The other places do need a close look, it seems that some of them may not be needed (e.g. the one inside "if (reuse) { }" at the top of do_wp_page() ... at the moment I'm struggling to see what it manages to achieve).
Most of the rest are in cases where we are adding a new virtual page (comments like "No need to invalidate - it was non-present before"). These may also need to have the order shuffled, but they seem unlikely to be the cause of a bug (it is unlikely that an application has threads that branch to new anonymous pages as they are being attached to the process).
So you are right that there may be some more work here, but I wanted to get the one-liner that is a clear and obvious bugfix posted without being cluttered with some less obvious fixes.
-Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |