lkml.org 
[lkml]   [2006]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Bugs in usb-skeleton.c??? :)
From
Date
 >> As I understand, USB subsystem uses urb->transfer_buffer directly with
>> DMA. I see that usb-skeleton.c and (at least) bluez's hci_usb allocates it
>> without GFP_DMA flag. (skeleton with GFP_KERNEL, bluez with GFP_ATOMIC)

AvdV> I think GFP_DMA means something different than that you think it means.
AvdV> GFP_DMA is a bad old hack that means "this is for ISA bus cards to DMA
AvdV> to/from". Since there are no ISA bus USB controllers... the USB code
AvdV> doesn't need to use GFP_DMA.

Does kmalloc always allocate pages that can be used in DMA?

I see pci_map_single gives address that incremented later without page
boundary checking. Are allocated pages sequented? (usb-ohci.c)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-13 14:37    [W:0.045 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site