Messages in this thread Patch in this message | | | Subject | Re: xfs fails dbench in 2.6.18-rc1-mm1 | From | Badari Pulavarty <> | Date | Wed, 12 Jul 2006 17:43:31 -0700 |
| |
On Wed, 2006-07-12 at 13:26 -0700, Martin Bligh wrote: > Badari Pulavarty wrote: > > Martin Bligh wrote: > > > >> Eric Dumazet wrote: > >> > >>> On Wednesday 12 July 2006 18:58, Martin Bligh wrote: > >>> > >>>> http://test.kernel.org/abat/40891/debug/test.log.1 > >>>> > >>>> Filesystem type for /mnt/tmp is xfs > >>>> write failed on handle 13786 > >>>> 4 clients started > >>>> Child failed with status 1 > >>>> write failed on handle 13786 > >>>> write failed on handle 13786 > >>>> write failed on handle 13786 > >>>> > >>>> Works fine in -git4 > >>>> All other fs's seemed to run OK. > >>>> > >>>> Machine is a 4x Opteron.
Sorry !! its my screw up again :( Here is the patch to fix it.
Thanks, Badari
Fix a bug in __xfs_file_write() which is causing writes to fail with -EINVAL.
Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>
Index: linux-2.6.18-rc1/fs/xfs/linux-2.6/xfs_file.c =================================================================== --- linux-2.6.18-rc1.orig/fs/xfs/linux-2.6/xfs_file.c 2006-07-11 21:28:08.000000000 -0700 +++ linux-2.6.18-rc1/fs/xfs/linux-2.6/xfs_file.c 2006-07-12 17:43:13.000000000 -0700 @@ -99,7 +99,7 @@ __xfs_file_write( BUG_ON(iocb->ki_pos != pos); if (unlikely(file->f_flags & O_DIRECT)) ioflags |= IO_ISDIRECT; - return bhv_vop_write(vp, iocb, &iov, nr_segs, &iocb->ki_pos, + return bhv_vop_write(vp, iocb, iov, nr_segs, &iocb->ki_pos, ioflags, NULL); }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |