Messages in this thread | | | Subject | Re: [PATCH] tpm: interrupt clear fix | From | Alan Cox <> | Date | Wed, 12 Jul 2006 23:04:08 +0100 |
| |
Ar Mer, 2006-07-12 am 14:01 -0700, ysgrifennodd Kylene Jo Hall: > Under stress testing I found that the interrupt is not always cleared. > This is a bug and this patch should go into 2.6.18 and 2.6.17.x. > > Signed-off-by: Kylene Hall <kjhall@us.ibm.com> > --- > --- tcg/tpmdd/drivers/char/tpm/tpm_tis.c 2006-06-07 11:37:08.000000000 -0700 > +++ linux-2.6.17/drivers/char/tpm/tpm_tis.c 2006-07-10 12:58:28.000000000 -0700 > @@ -424,6 +424,7 @@ static irqreturn_t tis_int_handler(int i > iowrite32(interrupt, > chip->vendor.iobase + > TPM_INT_STATUS(chip->vendor.locality)); > + mb();
NAK
This looks incorrect.
The iowrite32 will be posted for mmio. mb() may half hide the problem on some processors but you should read from the same PCI device as per the PCI spec.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |