Messages in this thread | | | Subject | Re: [openib-general] ipoib lockdep warning | From | Roland Dreier <> | Date | Tue, 11 Jul 2006 16:43:18 -0700 |
| |
Hmm, good point.
It sort of seems to me like the idr interfaces are broken by design. Internally, lib/idr.c uses bare spin_lock(&idp->lock) with no interrupt disabling or anything in both the idr_pre_get() and idr_get_new() code paths. But idr_pre_get() is supposed to be called in a context that can sleep, while idr_get_new() is supposed to be called with locks held to serialize things (at least according to http://lwn.net/Articles/103209/).
So, ugh... maybe the best thing to do is change lib/idr.c to use spin_lock_irqsave() internally?
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |