lkml.org 
[lkml]   [2006]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.18-rc1-mm1: drivers/ide/pci/jmicron.c warning
Alan Cox <alan@redhat.com> wrote:
>
> I'd say that gcc warning in the case that all the enum values are enumerated
> and have returns is a broken warning irrespective of that so I won't "fix" it
> because it isn't broken. Its just like various other bogus gcc warnings
>

But we work around gcc problems all the time.

Warnings like this have a cost - they make the build noisy and that causes
people to miss real bugs which the compiler is trying to tell them about.

So if we can implement a low-cost fix for this then we should do so.


--- a/drivers/ide/pci/jmicron.c~a
+++ a/drivers/ide/pci/jmicron.c
@@ -94,8 +94,9 @@ static int __devinit ata66_jmicron(ide_h
return 0;
return 1;
case PORT_SATA:
- return 1;
+ break;
}
+ return 1; /* Avoid bogus "control reaches end of non-void function" */
}

static void jmicron_tuneproc (ide_drive_t *drive, byte mode_wanted)
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-07-12 01:27    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site