Messages in this thread | | | Date | Tue, 11 Jul 2006 10:58:00 -0700 | From | "Ray Lee" <> | Subject | Re: [patch] i386: handle_BUG(): don't print garbage if debug info unavailable |
| |
On 7/11/06, Linus Torvalds <torvalds@osdl.org> wrote: > On Tue, 11 Jul 2006, Nick Piggin wrote: > > > > OK but you don't need a do/while(0) here. > > Actually, the way Andrew wrote it, it _is_ needed. It does two things: > > - it's the block scope that allows the private variables > - if the "get_user()" fails, the "break" means that you don't have to > have a goto.
<pedantry> The latter is true, but the former can also be done with just bare braces:
int a=4; { int a=3; printf("%d ",a); /* 3 */ } printf("%d ",a); /* 4 */
</pedantry, only useful to those who wish to write ugly code or source code parsers>
Not being a person with actual *useful* skills, I can't comment on the __get_user() issue :-).
Ray - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |