Messages in this thread | | | Date | Tue, 11 Jul 2006 23:21:39 +0800 | From | "Antonino A. Daplas" <> | Subject | Re: [PATCH] fbdev: Statically link the framebuffer notification functions |
| |
Jon Smirl wrote: > On 7/11/06, Antonino A. Daplas <adaplas@gmail.com> wrote: >> > The code looks ok but this sure smells like inter_module_*. >> >> I assure you, there is no smell of inter_module_* here. What scenario >> are you afraid of? > > Dangling references during the load/unload process. That was > inter_module's problem.
That won't happen. If fbdev unloads, then the module that does the notification disappears, and the clients won't receive notifications. If the client is the one that unloads first, it unregisters its notifier block, and that's one less client for fbdev to notify (And fbdev doesn't know how many clients are there, that's internal to the notifier). And since registration, unregistration and the call to the callout function in the notifier block are protected by a semaphore (in the blocking type), the danger of unregistration while in the midst of a notification is removed.
Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |