Messages in this thread | | | Date | Tue, 11 Jul 2006 14:15:48 +0100 | From | Paulo Marques <> | Subject | Re: tty's use of file_list_lock and file_move |
| |
Jon Smirl wrote: >[...] > extern struct tty_driver *ptm_driver; /* Unix98 pty masters; for /dev/ptmx */ > @@ -158,21 +157,21 @@ static struct tty_struct *alloc_tty_stru > { > struct tty_struct *tty; > > - tty = kmalloc(sizeof(struct tty_struct), GFP_KERNEL); > - if (tty) > - memset(tty, 0, sizeof(struct tty_struct)); > + tty = kmalloc(sizeof(*tty), GFP_KERNEL); ^^^^^^^ kzalloc?
I don't know this code very well, so you might be actually changing the initialization here. On the other hand, this might be just a simple bug...
-- Paulo Marques - www.grupopie.com
Pointy-Haired Boss: I don't see anything that could stand in our way. Dilbert: Sanity? Reality? The laws of physics? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |