Messages in this thread | | | Date | Mon, 10 Jul 2006 18:20:54 -0400 | From | Mike Grundy <> | Subject | Re: [PATCH] kprobes for s390 architecture |
| |
On Mon, Jul 10, 2006 at 11:28:52AM +0200, Heiko Carstens wrote: > Whitespace :) d'oh. > You need a label behind the cs instruction and put that into the __ex_table, > since the PSW will point to the instruction after cs if it fails. Yeah, thought that was a nullify not a terminate. d'oh. d'oh.
> Also, on failure this function seems to return -EFAULT >> shift, which > seems to be wrong. Yeah. I think just returning the value without the shift would be ok. kprobes never checks to see if the instruction swap was successful (which seems even more wrong)
> > +EXPORT_SYMBOL(register_die_notifier); > > +EXPORT_SYMBOL(unregister_die_notifier); > _GPL? Makes sense, but I kept it consistent with the rest of kprobes.
-- Thanks Mike
========================================= Michael Grundy - grundym@us.ibm.com
If at first you don't succeed, call in an air strike.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |