lkml.org 
[lkml]   [2006]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 2/9] -Wshadow: Fix warnings in mconf
On Mon, 2006-07-10 17:53:37 +0200, Martin Waitz <tali@admingilde.org> wrote:
> On Mon, Jul 10, 2006 at 01:12:37PM +0200, Jesper Juhl wrote:
> > --- linux-2.6.18-rc1-orig/scripts/kconfig/mconf.c 2006-06-18 03:49:35.000000000 +0200
> > +++ linux-2.6.18-rc1/scripts/kconfig/mconf.c 2006-07-09 19:48:05.000000000 +0200
> > @@ -276,7 +276,7 @@ static void conf_save(void);
> > static void show_textbox(const char *title, const char *text, int r, int c);
> > static void show_helptext(const char *title, const char *text);
> > static void show_help(struct menu *menu);
> > -static void show_file(const char *filename, const char *title, int r, int c);
> > +static void show_file(const char *fname, const char *title, int r, int c);
> >
> > static void cprint_init(void);
> > static int cprint1(const char *fmt, ...);
>
> perhaps its more clear if you change the global variable instead?
> perhaps to config_filename?

After all, that's just a declaration. I doubt that GCC should warn
here at all...

MfG, JBG

--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
für einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-07-10 18:23    [W:0.851 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site