Messages in this thread | | | Date | Sat, 1 Jul 2006 02:39:50 -0600 | From | Andreas Dilger <> | Subject | Re: [RFC 1/2] ext3: enlarge blocksize and fix rec_len overflow |
| |
On Jun 30, 2006 11:19 -0700, Daniel Phillips wrote: > OK, just to handle the 64K case, what is wrong with treating 0 as 64K?
Hmm, good question - it's impossible to have a valid rec_len of 0 bytes. There would need to be some special casing in the directory handling code. Also, it breaks some of the directory sanity checking, and since "0" is a common corruption pattern it isn't great to use. We could instead use 0xfffc to mean 0x10000 since they are virtually the same value and the error checking is safe. It isn't possible to have this as a valid value.
Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |