Messages in this thread | | | Date | Fri, 9 Jun 2006 18:37:37 +0200 (CEST) | From | Roman Zippel <> | Subject | Re: [PATCH] fix generic HDLC synclink mismatch build error |
| |
Hi,
On Fri, 9 Jun 2006, Paul Fulghum wrote:
> Roman Zippel wrote: > > > +config SYNCLINK_HDLC > > > + bool "Generic HDLC support for SyncLink driver" > > > + depends on SYNCLINK > > > + depends on HDLC=y || HDLC=SYNCLINK > > > > > > If you replace now 'bool "..."' with 'def_bool y', it's enabled > > automatically as soon as HDLC is enabled and the user doesn't has to confirm > > it for every driver separately and it has the same effect as your #ifdef > > hack. > > You need to explain this more.
Just try it. :)
> The only #ifdef in the patch is that which conditionally > compiles the generic HDLC support based on the > kernel configuration option. If I remove those, then > the synclink would require generic HDLC, which > is not what we want.
I meant the old #ifdef hack, which your patch removed.
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |