Messages in this thread | | | Date | Thu, 08 Jun 2006 01:54:45 +0200 | From | Stefan Richter <> | Subject | Re: 2.6.17-rc6-mm1 |
| |
Ingo Molnar wrote: ... > ieee1394 reuses the skb infrastructure of the networking code, > and uses two skb-head queues: ->pending_packet_queue and > hpsbpkt_queue. The latter is used in the usual fashion: processed > from a kernel thread. The other one, ->pending_packet_queue is also > processed from hardirq context (f.e. in hpsb_bus_reset()), which is > not what the networking code usually does (which completes from > softirq or process context). This locking assymetry can be totally > correct if done carefully, but it can also be dangerous if > networking helper functions are reused, which could assume > traditional networking use. ...
The pending_packet_queue is only accessed from within drivers/ieee1394/ieee1394_core.c, and only via net/core/skbuff.c's access functions for queueing/ dequeueing/ queuewalking. Or am I missing something? -- Stefan Richter -=====-=-==- -==- -=--- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |