lkml.org 
[lkml]   [2006]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] fix missing hdlc symbols for synclink drivers
From
Date
On Wed, 2006-06-07 at 01:37 +0200, Krzysztof Halasa wrote:
> "Randy.Dunlap" <rdunlap@xenotime.net> writes:
>
> > I'm on x86-64 if it matters.
> > My .config is attached.
>
> Ok, reproduced.
>
> The problem is that CONFIG_WAN is not set, the make system doesn't
> read drivers/net/wan/Makefile at all, and nothing in drivers/net/wan
> is being built.
>
> Just another argument against random SELECTs.

OK, I thought he was building with the latest patch (attached here),
which adds the 'select WAN' reverse dependency.
I tested his .config with the patch (minus the Makefile portion) and
it builds just fine.

There is nothing random about these select statements.
They are chosen specifically to fix the dependencies.
You may feel they are ugly, but 'select' is the only tool
I know of that fixes these errors without losing flexibility.


--- linux-2.6.17-rc5-mm3/drivers/char/Kconfig 2006-06-06 14:03:58.000000000 -0500
+++ b/drivers/char/Kconfig 2006-06-06 14:08:53.000000000 -0500
@@ -197,6 +197,7 @@ config ISI
config SYNCLINK
tristate "SyncLink PCI/ISA support"
depends on SERIAL_NONSTANDARD && PCI && ISA_DMA_API
+ select WAN if SYNCLINK_HDLC
select HDLC if SYNCLINK_HDLC
help
Driver for SyncLink ISA and PCI synchronous serial adapters.
@@ -214,6 +215,7 @@ config SYNCLINK_HDLC
config SYNCLINKMP
tristate "SyncLink Multiport support"
depends on SERIAL_NONSTANDARD && PCI
+ select WAN if SYNCLINKMP_HDLC
select HDLC if SYNCLINKMP_HDLC
help
Driver for SyncLink Multiport (2 or 4 ports) PCI synchronous serial adapter.
@@ -231,6 +233,7 @@ config SYNCLINKMP_HDLC
config SYNCLINK_GT
tristate "SyncLink GT/AC support"
depends on SERIAL_NONSTANDARD && PCI
+ select WAN if SYNCLINK_GT_HDLC
select HDLC if SYNCLINK_GT_HDLC
help
Support for SyncLink GT and SyncLink AC families of
--- linux-2.6.17-rc5-mm3/drivers/char/pcmcia/Kconfig 2006-06-06 14:03:58.000000000 -0500
+++ b/drivers/char/pcmcia/Kconfig 2006-06-06 14:09:25.000000000 -0500
@@ -8,6 +8,7 @@ menu "PCMCIA character devices"
config SYNCLINK_CS
tristate "SyncLink PC Card support"
depends on PCMCIA
+ select WAN if SYNCLINK_CS_HDLC
select HDLC if SYNCLINK_CS_HDLC
help
Driver for SyncLink PC Card synchronous serial adapter.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-07 01:59    [from the cache]
©2003-2011 Jasper Spaans