Messages in this thread | | | Subject | Re: [linuxsh-dev] [Alsa-devel] [PATCH] Add support for Yamaha AICA sound on SEGA Dreamcast | From | Adrian McMenamin <> | Date | Wed, 07 Jun 2006 00:10:48 +0100 |
| |
On Tue, 2006-06-06 at 12:25 +0200, Takashi Iwai wrote:
> > As Paul already pointed, the platform_device things must be fixed. > Also, better to clean up the code directly accessing hardcoded > addresses.
Working on that, some new code in my personal CVS now - but I suspect it will be the weekend before that gets fully fixed.
> > Another big concern is that spu_dma_work is initialized/rewritten > dynamically in spu_begin_dma() and aica_period_elapsed() via > INIT_WORK() and PREPARE_WOR(). This looks pretty strange and may be > racy.
Actually, the two macros INIT_WORK and PREPARE_WORK use the same work queue but ask it to schedule the execution of two different (if very similar) functions start_spu_dma() - which does the initial transfer and more_spu_dma - which tops up the dma transfers.
So I think I've got that right.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |