lkml.org 
[lkml]   [2006]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.17-rc5-mm1
    On Tue, 6 Jun 2006, Christoph Lameter wrote:
    >
    > It evaluates to 31 it seems for all platforms. Could we replace this
    > expression with MAX_SWAPFILES? While we at it get rid of the "type"
    > variable because we are usually using pointers to swap_info.

    Well, if you want to go through all of swapfile.c, changing it over
    to use pointers rather than type/indexes. But I don't think it's
    worth it, and I don't think it should be mixed in with this fix.

    > Note that there is still another similar check in there for an arch
    > specific test of the number of pages available per swap device.

    And that check, also Martin's I believe, has very good justification:
    it will vary from arch to arch how big a swap area they can handle, and
    his check is the right way to do it - no more obscure than it has to be.

    Hugh
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-06 20:23    [W:4.404 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site