lkml.org 
[lkml]   [2006]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/4] Twofish cipher - x86_64 assembler
    Date
    On Monday 05 June 2006 12:06, Joachim Fritschi wrote:
    > On Sunday 04 June 2006 21:10, Andi Kleen wrote:
    > > On Sunday 04 June 2006 15:16, Joachim Fritschi wrote:
    > > > This patch adds the twofish x86_64 assembler routine.
    > > >
    > > > Changes since last version:
    > > > - The keysetup is now handled by the twofish_common.c (see patch 1 )
    > > > - The last round of the encrypt/decrypt routines where optimized saving 5
    > > > instructions.
    > > >
    > > > Correctness was verified with the tcrypt module and automated test
    > > > scripts.
    > >
    > > Do you have some benchmark numbers that show that it's actually worth
    > > it?
    >
    > Here are the outputs from the tcrypt speedtests. They haven't changed much
    > since the last patch:

    Ok thanks. I've tried to apply the patches, but can't because they're
    word wrapped. Can you please resend and do a test send to yourself first,
    checking that the patch can be really applied.


    > There might be some way to further improve readability but i have not found
    > any other way. I'm open to suggestions :)


    Sounds reasonable. Best you just fix the comment to say that this convention is needed
    for the macros.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-06 01:38    [W:8.640 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site